[PATCH] D117922: InferFunctionAttrs: fix assertion on aligned_alloc

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 12:54:19 PST 2022


reames added a comment.

In D117922#3270243 <https://reviews.llvm.org/D117922#3270243>, @jyknight wrote:

> In D117922#3269582 <https://reviews.llvm.org/D117922#3269582>, @durin42 wrote:
>
>> I'm very open to suggestions on how to reword the commit message here, BTW. I thought it was clear, but seems not. :(
>
> The miscommunication here is that you meant "Fix a test-case to actually verify the behavior it was supposed to", whereas philip read it as "fixes an `assert(...)` failure"...by adjusting a test.

If you say so.  I see no way to get the former from the patch description, but that's probably the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117922/new/

https://reviews.llvm.org/D117922



More information about the llvm-commits mailing list