[PATCH] D118401: [MC] Remove a stray space after tab for COFF .def directives

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 12:01:17 PST 2022


mstorsjo created this revision.
mstorsjo added reviewers: asl, rnk.
Herald added a subscriber: hiraditya.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

This extra stray space after tab can be traced back to when printing
of this directive was added originally in
4f01b783a3ca5b2544fe1b1677b5bcf6d91c6d2c. The same commit added
inconsistent printing of space after the ELF .type directive too,
which was fixed later in
77fe07a93aeb8feaf39b7d48ad8fc1e6c9e4c78e.

(This is kind of NFC, but it does alter the output, so it's not
strictly non-functional in that sense.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118401

Files:
  llvm/lib/MC/MCAsmStreamer.cpp


Index: llvm/lib/MC/MCAsmStreamer.cpp
===================================================================
--- llvm/lib/MC/MCAsmStreamer.cpp
+++ llvm/lib/MC/MCAsmStreamer.cpp
@@ -788,7 +788,7 @@
 }
 
 void MCAsmStreamer::BeginCOFFSymbolDef(const MCSymbol *Symbol) {
-  OS << "\t.def\t ";
+  OS << "\t.def\t";
   Symbol->print(OS, MAI);
   OS << ';';
   EmitEOL();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118401.403744.patch
Type: text/x-patch
Size: 362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220127/917bd362/attachment.bin>


More information about the llvm-commits mailing list