[PATCH] D118168: [LLVM] Introduce llvm.loop.finite metadata to represent loops which are known to iterate a finite number of times

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I think this is generally sensible but lacks tests and a clear path towards usage. Who will produce the annotation?



================
Comment at: llvm/include/llvm/Analysis/LoopInfo.h:1345
+bool isFinite(const Loop *L);
+
 /// Return true if this loop can be assumed to make progress.  (i.e. can't
----------------
Why do we need both, esp. given the Note?


================
Comment at: llvm/lib/Analysis/LoopInfo.cpp:1126
 
+static const char *LLVMLoopFinite = "llvm.loop.finite";
+
----------------
While it seems to be the state-of-the-art to duplicate the string all over the place, could we please start a new scheme in which we have this definition early in the file and used whenever we need the string. Feel free to update the other ones as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118168/new/

https://reviews.llvm.org/D118168