[PATCH] D118328: [CodeGen] Emit COFF symbol type for function aliases

Thu Jan 27 11:11:51 PST 2022

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1653
+    if (TM.getTargetTriple().isOSBinFormatCOFF()) {
+      OutStreamer->BeginCOFFSymbolDef(Name);
+      OutStreamer->EmitCOFFSymbolStorageClass(
----------------
I see that these directives are emitted in the ARM, AArch64, and X86 AsmPrinter subclasses instead of here in the main asm printer. However, I think it makes more sense to put them here the way you have it. They are common to all COFF targets.

So, no need to make any changes, just an idea for a cleanup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118328/new/

https://reviews.llvm.org/D118328