[PATCH] D118315: [ADT] Refactor comparison operator in APSInt by compareValues

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 10:10:18 PST 2022


rjmccall added a comment.

`compareValues` is a specific request to do a comparison of the represented integer values.  It's fine to have API like that which ignores bit-width and signedness; it doesn't change that ordinary comparisons should require no bit-width and signedness differences in order to protect against accidental mis-use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118315/new/

https://reviews.llvm.org/D118315



More information about the llvm-commits mailing list