[PATCH] D116180: [InstrProf] Add single byte coverage mode

[Ellis Hoag via Phabricator via llvm-commits]

ellis added a comment.

@davidxl @phosek @kyulee Can I get another look at this?



================
Comment at: llvm/docs/LangRef.rst:13140
+
+      declare void @llvm.instrprof.cover(i8* <name>, i64 <hash>)
+
----------------
ellis wrote:
> davidxl wrote:
> > probably name it llvm.instrprof.entry_cover to reflect the semantics. In theory you can have block level coverage mode too.
> I agree. Renaming to `llvm.instrprof.entry_cover`.
I renamed it to `llvm.instrprof.cover` because this would be used for block coverage.


================
Comment at: llvm/include/llvm/ProfileData/InstrProfReader.h:484
 
+  bool useSingleByteEntryCoverage() const override {
+    return (FormatVersion & VARIANT_MASK_BYTE_ENTRY_COVERAGE) != 0;
----------------
davidxl wrote:
> entry coverage is compatiable with IR pgo -- so perhaps add an assertion somewhere.
I added an assertion in `PGOInstrumentation.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116180/new/

https://reviews.llvm.org/D116180