[PATCH] D118317: [InstCombine] Fold and-reduce idiom

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:5902
+  Value *LHS = InnerICmp->getOperand(0);
+  Value *RHS = InnerICmp->getOperand(1);
+  auto *LHSTy = dyn_cast<FixedVectorType>(LHS->getType());
----------------
mkazantsev wrote:
> RKSimon wrote:
> > Is it worth using the pattern match helpers to match all of this?
> That's what I tried initially, but for single use checks we'd still need to extract all intermediate values and cast them to instructions.
Let's give it another try, maybe will be better after all refactoring we've done...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118317/new/

https://reviews.llvm.org/D118317