[PATCH] D118381: [flang][driver][nfc] Fix capitalisation

[Valentin Clement via Phabricator via llvm-commits]

clementval accepted this revision.
clementval added a comment.

LGTM



================
Comment at: flang/include/flang/Frontend/CompilerInstance.h:120
   /// Replace the current stream for verbose output.
   void set_semaOutputStream(std::unique_ptr<llvm::raw_ostream> Value);
 
----------------
awarzynski wrote:
> clementval wrote:
> > What about this one? And the three below?
> From: https://github.com/llvm/llvm-project/blob/main/flang/docs/C%2B%2Bstyle.md#naming
> 
> >  3. Mutator member functions are named set_...
> 
> This patch updates methods that were meant to be named according to:
> > 4. Other class functions should be named with leading capital letters, CamelCase, and no underscores, 
> 
> If we were to do this diligently, we'd need to audit all member methods and decide what qualifies as a "mutator" and what is a "class function".  Or, IMHO better, one could refactor the driver to use the MLIR style (i.e. one rule for both).
Ok thanks for the clarification. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118381/new/

https://reviews.llvm.org/D118381