[PATCH] D118357: [test-release.sh] Set TEST_SUITE_HOST_CC to the release testing build compiler when compiling test-suite tools.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 05:49:43 PST 2022


amyk created this revision.
amyk added reviewers: tstellar, nemanjai, Meinersbur.
amyk added a project: LLVM.
amyk requested review of this revision.

The tools used by test-suite are originally configured to compile with `cc` by default, 
and this is dictated by `TEST_SUITE_HOST_CC.` 
However, it is possible that on some systems that the version of `cc` may either not be
present or it may not be able to compile the tools as it may be too old, which could be
an issue seen during release testing.

This patch updates the compiler to be the default build compiler that is used for release
testing. If no such compiler it specified, then `cc` will be set as the test-suite tools build
compiler by default (as it already is set under `TEST_SUITE_HOST_CC`).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118357

Files:
  llvm/utils/release/test-release.sh


Index: llvm/utils/release/test-release.sh
===================================================================
--- llvm/utils/release/test-release.sh
+++ llvm/utils/release/test-release.sh
@@ -452,7 +452,8 @@
     if [ $do_test_suite = 'yes' ]; then
       cd $TestSuiteBuildDir
       env CC="$c_compiler" CXX="$cxx_compiler" \
-          cmake $TestSuiteSrcDir -G "$generator" -DTEST_SUITE_LIT=$Lit
+          cmake $TestSuiteSrcDir -G "$generator" -DTEST_SUITE_LIT=$Lit \
+                -DTEST_SUITE_HOST_CC=$build_compiler
 
       if ! ( ${MAKE} -j $NumJobs $KeepGoing check \
           2>&1 | tee $LogDir/llvm.check-Phase$Phase-$Flavor.log ) ; then
@@ -548,6 +549,8 @@
 
     c_compiler="$CC"
     cxx_compiler="$CXX"
+    build_compiler="$CC"
+    [[ -z "$build_compiler" ]] && build_compiler="cc"
     llvmCore_phase1_objdir=$BuildDir/Phase1/$Flavor/llvmCore-$Release-$RC.obj
     llvmCore_phase1_destdir=$BuildDir/Phase1/$Flavor/llvmCore-$Release-$RC.install
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118357.403621.patch
Type: text/x-patch
Size: 972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220127/b415dd9a/attachment.bin>


More information about the llvm-commits mailing list