[PATCH] D118353: [ARM] Don't look through pointer types in canTailPredicateLoop()

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: SjoerdMeijer, samparker, dmgreen.
Herald added subscribers: hiraditya, kristof.beyls.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Inspecting the pointer element type here is incompatible with opaque pointers, and doesn't seem necessary to me. I think the intention here might have been to check the type of load/store pointer arguments, but I believe those should get checked through their return type or value operand anyway. I don't get any test failures if I simply drop this.


https://reviews.llvm.org/D118353

Files:
  llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp


Index: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
===================================================================
--- llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
+++ llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
@@ -2109,9 +2109,6 @@
       }
 
       Type *T  = I.getType();
-      if (T->isPointerTy())
-        T = T->getPointerElementType();
-
       if (T->getScalarSizeInBits() > 32) {
         LLVM_DEBUG(dbgs() << "Unsupported Type: "; T->dump());
         return false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118353.403618.patch
Type: text/x-patch
Size: 491 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220127/29af2e46/attachment.bin>