[PATCH] D118317: [InstCombine] Fold and-reduce idiom

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 27 05:01:18 PST 2022


mkazantsev updated this revision to Diff 403605.
mkazantsev marked 4 inline comments as done.
mkazantsev added a reviewer: lebedev.ri.
mkazantsev added a comment.

Addressed Roman's comments:

- LHS type hoisted
- Comments added
- Vars renamed
- As for relaxation of legal type to "not wider than max legal type" - I could not find proper API easily. Maybe it needs some extra infrastructure work, and need to check legality. So I added TODO, lets postpone this. I think in most practical cases vector width is power of 2 and all such types are legal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118317/new/

https://reviews.llvm.org/D118317

Files:
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/test/Transforms/InstCombine/icmp-vec.ll
  llvm/test/Transforms/InstCombine/reduction-and-sext-zext-i1.ll
  llvm/test/Transforms/InstCombine/reduction-or-sext-zext-i1.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118317.403605.patch
Type: text/x-patch
Size: 6139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220127/3aa9c5ba/attachment.bin>


More information about the llvm-commits mailing list