[PATCH] D118340: [test][NewGVN] Use '-aa-pipeline=basic-aa -passes=newgvn' instead of '-basic-aa -newgvn'

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D118340#3275411 <https://reviews.llvm.org/D118340#3275411>, @nikic wrote:

> Can you please omit `-aa-pipeline` entirely where it makes no difference to test output? Especially for basic-aa, it should not be necessary to explicitly specify it.

I was afraid that the reason for having explicitly added `-basic-aa` in the original test case might have indicated that basic-aa was needed to expose the bug etc.
But ofcourse, since with legacy PM "opt -basic-aa -newgvn" and "opt -newgvn" would give the same result one might question why these tests has been explicitly mentioning `-basic-aa` from the start.

So in the end I guess this patch really isn't much different from D118341 <https://reviews.llvm.org/D118341> were I'm handling tests that did not specify `-basic-aa`. I'll look into omitting `-aa-pipeline` in these tests as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118340/new/

https://reviews.llvm.org/D118340