[PATCH] D118341: [test][NewGVN] Use -passes=newgvn instead of -newgvn

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/opt-remarks-xfail.ll:5
 ; RUN: cat %t | FileCheck -check-prefix=YAML %s
 ; RUN: opt < %s -passes=newgvn -o /dev/null  -pass-remarks-output=%t -S -pass-remarks=gvn \
 ; RUN:     2>&1 | FileCheck %s
----------------
this is now redundant?


================
Comment at: llvm/test/Transforms/NewGVN/pr32403.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-;RUN: opt -newgvn -S < %s | FileCheck %s
+;RUN: opt -passes=newgvn -S < %s | FileCheck %s
 target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
----------------
tiniest nit: while you are here, also add a space after `;`?


================
Comment at: llvm/test/Transforms/NewGVN/pr33014.ll:3
 ; REQUIRES: asserts
-; RUN: opt -newgvn -S %s | FileCheck %s
+; RUN: opt -passes=newgvn -S %s | FileCheck %s
 
----------------
While you are here, maybe also drop `REQUIRES; asserts`? The test checks for the full IR output and no debug output, so there's no need for assertions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118341/new/

https://reviews.llvm.org/D118341