[PATCH] D115035: Move header ConstantFold.h into include directory

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 23:08:52 PST 2022


sepavloff added a comment.

In D115035#3273211 <https://reviews.llvm.org/D115035#3273211>, @RKSimon wrote:

> In D115035#3273092 <https://reviews.llvm.org/D115035#3273092>, @sepavloff wrote:
>
>> D110322 <https://reviews.llvm.org/D110322> was remade and this change is not necessary for it anymore. But this change could be needed it we modify constant evaluation for constrained intrinsics by moving the evaluation into a separate pass.
>>
>> Do you need these patch? If yes, I will commit it.
>
> I was mainly triaging accepted-but-uncommited phabs in the run up to the 14.x branch, but I see no harm in committing this if you see a future use, or maybe abandon it (no pressure though!) to avoid bitrot?

I created D118319 <https://reviews.llvm.org/D118319>, depending on review feedback destiny of this patch will be resolved in a couple of days.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115035/new/

https://reviews.llvm.org/D115035



More information about the llvm-commits mailing list