[PATCH] D118249: [demangler] remove StdQualifiedName

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 18:54:05 PST 2022


ChuanqiXu added a comment.

Do you say: we would use `StdQualifiedName` for names in `::std` originally and use `NameType` with value `std` for names in something like `NamespaceA::std::`? If I understand correctly, I feel that it might not be a good choice. I think the current design makes the semantics more clear and it have a higher level of abstraction. The description says the main intention is to make code shorter. But I feel that the shorter code is not always simpler to understand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118249/new/

https://reviews.llvm.org/D118249



More information about the llvm-commits mailing list