[PATCH] D89050: Add support for !noundef metatdata on loads
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 26 17:23:38 PST 2022
aqjune added a comment.
In D89050#3272837 <https://reviews.llvm.org/D89050#3272837>, @malharJ wrote:
>> Right, but the absence of select -> and/or folding by itself shouldn't matter -- it's only relevant in that it can prevent other transforms
>
> I fully agree, it's just that the presence of that transformation was helping with an optimization later on in the pipeline
> in my specific case.
>
> Otherwise there is no issue with code generation of select.
Hi @malharJ,
The clang change (!noundef) makes sense to me, unless the load type is unsigned char. The unsigned char case is slightly complicated.
If the other optimization which was blocked by the disabled select->and/or present in the current LLVM mainstream, could you share the optimization? I am willing to look into it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89050/new/
https://reviews.llvm.org/D89050
More information about the llvm-commits
mailing list