[PATCH] D118286: [WebAssembly] Error out for setjmp within catch clause for Wasm SjLj

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 15:58:34 PST 2022


aheejin added a comment.

In D118286#3273921 <https://reviews.llvm.org/D118286#3273921>, @dschuff wrote:

> `Wasm EH, used with either of Emscripten EH or Wasm EH, does not allow`
> Do you mean "Wasm SjLj?"

The main culprit(?) is Wasm EH. This doesn't work for Wasm EH + Emscripten SjLj either. But Wasm EH + Emscripten SjLj, which was never meant to be a final recommended way to use EH + SjLj but was used as an interim step until Wasm SjLj is not done, even has

  https://github.com/llvm/llvm-project/blob/f32dccb9a43b02ce4e540d6ba5dbbdb188f2dc7d/llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp#L1495-L1498
  ```,  so using `setjmp` with `try`-`catch` within the same function will fail anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118286/new/

https://reviews.llvm.org/D118286



More information about the llvm-commits mailing list