[PATCH] D118276: Adding a DIBuilder interface for Fortran's assumed length string

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 added a comment.

I just added a new field StringLocationExp to DIStringType in this commit: https://reviews.llvm.org/rG28bfa57a7315c3161124c90b4d52f467616dc92e . Please add an optional argument to these createStringType functions so that the caller can specify this new field if it desires.



================
Comment at: llvm/include/llvm/IR/DIBuilder.h:228
+    /// \param stringLength  Metadata refrencing string length.
+    DIStringType *createStringType(StringRef Name, Metadata *stringLength);
+    
----------------
stringLength can be typed as DIVariable *.

Side note: LLVM coding convention calls for capital first letter of a variable name; so stringLength -> StringLength.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118276/new/

https://reviews.llvm.org/D118276