[PATCH] D118271: [BOLT] Prepare BOLT for unit-testing

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 12:36:52 PST 2022


maksfb accepted this revision.
maksfb added a comment.

Summary: "Remove positional InputFilename..." -> "Move positional InputFilename...".

I'm not a cmake expert, but the rest of the changes LGTM.



================
Comment at: bolt/CMakeLists.txt:79
 if (BOLT_INCLUDE_TESTS)
+  if(EXISTS ${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include/gtest/gtest.h)
+    add_subdirectory(unittests)
----------------



================
Comment at: bolt/unittests/CMakeLists.txt:2
+add_custom_target(BoltUnitTests)
+set_target_properties(BoltUnitTests PROPERTIES FOLDER "Bolt tests")
+
----------------
nit:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118271/new/

https://reviews.llvm.org/D118271



More information about the llvm-commits mailing list