[PATCH] D118058: [SelectionDAG][VP] Provide expansion for VP_MERGE
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 26 11:21:58 PST 2022
craig.topper added a comment.
In D118058#3266832 <https://reviews.llvm.org/D118058#3266832>, @frasercrmck wrote:
> I haven't done much work in expansions so don't know exactly how/when best to check to unroll. For example, I didn't want to check whether `VSELECT` was marked as `Expand` because we rely on that expansion. But if the VSELECT were to unroll then arguably VP_MERGE should unroll.. So should the expansion of VP_MERGE duplicate logic that should be internal to ExpandVSELECT?
I think I'm ok not duplicating it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118058/new/
https://reviews.llvm.org/D118058
More information about the llvm-commits
mailing list