[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 added inline comments.


================
Comment at: clang/include/clang/Driver/Driver.h:45
+class Command;
+class Compilation;
+class JobList;
----------------
JonChesterfield wrote:
> This looks like it should be a breaking change - InputInfo is no longer forward declared. Would it be reasonable to keep the forward declaration and put the typedef between class statements and the LTOKind enum?
We can't forward declare a struct and use it by-value in a container, I would need to change it to a pointer. It's doable, but I don't think it's ideal. I'm not sure why this would break anything, the forward declarations simply were there to avoid including more files here. I could be wrong however.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116541/new/

https://reviews.llvm.org/D116541