[PATCH] D110450: [LLD] Remove global state in lld/COFF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 11:01:28 PST 2022


MaskRay added a comment.

If other ports want to follow suit, I think storing `const COFFLinkerContext &ctx;` in classes like `*File` are fine since the instances are not too many.

Placing the member in `*Section` is definitely too wasteful. For classes like `ImportThunkChunk`, I think it'd be better to avoid storing the member as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110450/new/

https://reviews.llvm.org/D110450



More information about the llvm-commits mailing list