[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Sorry for the belated response.

I support refining uwtable to two values.

In D114543#3273164 <https://reviews.llvm.org/D114543#3273164>, @efriedma wrote:

> I'd like to see names, not numbers, in printed LLVM IR attributes.  It's more clear what it's supposed to mean, and it's easier to adjust in the future.

Do you have a suggestion for the sync unwind tables attribute name? syncuwtable?

> Did you mean to update https://llvm.org/docs/LangRef.html#synthesized-functions-module-flags-metadata ?

Then `“uwtable”: Max. The value can be 0 or 1. If the value is 1, a synthesized function will get the uwtable function attribute.` will need note that `syncuwtable` is part of the `uwtable` family.



================
Comment at: llvm/lib/IR/Attributes.cpp:214
+}
+
+
----------------
delete excessive blank line


================
Comment at: llvm/lib/IR/Attributes.cpp:466
+      std::string Result = "uwtable";
+      if (Kind != UWTableKind::Default) {
+        Result += '(';
----------------
`Result += ('(' + Twine(unsigned(kind)) + ')').str();`


================
Comment at: llvm/test/Bitcode/attributes.ll:520
+; CHECK: define void @f84() #51
+define void @f84() uwtable(1)
+{
----------------
Place `{` in the prevailing position


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114543/new/

https://reviews.llvm.org/D114543