[PATCH] D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop

Wed Jan 26 10:08:47 PST 2022

efriedma added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:591
 // This function has special handling of stack tagging loop pseudos, in which
 // case it can also change the instruction opcode (but not the operands).
 static Register
----------------
"but not the operands" needs to be updated.

================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:593
 static Register
-createScratchRegisterForInstruction(MachineInstr &MI,
+createScratchRegisterForInstruction(MachineInstr &MI, unsigned FIOperandNum,
                                     const AArch64InstrInfo *TII) {
----------------
Maybe rename this helper?  Not a big deal either way.

================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:601
+                : MI.getOpcode() == AArch64::STZGloop ? AArch64::STZGloop_wback
+                                                      : 0 /* unused */;
+  if (MI.getOpcode() == AArch64::STGloop ||
----------------
Minor nit: move the definition of "Op" inside the if statement.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114548/new/

https://reviews.llvm.org/D114548