[PATCH] D118135: [demangler] preserve line numbering in copied sources

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 09:42:53 PST 2022


dblaikie added a comment.

In D118135#3272068 <https://reviews.llvm.org/D118135#3272068>, @ChuanqiXu wrote:

> @tstellar @dblaikie @Quuxplusone I want to ask if it is important to keep the filename in the file headers. I couldn't be sure about this. You guys looks experienced to answer the question than me.

General question about LLVM style, or are you wondering about a special consideration/exception for these special cloned files? I don't know of any especially important reason that they /must/ be there if there's particular value in not having them in this case... - but maybe other folks know more/different/have other feelings about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118135/new/

https://reviews.llvm.org/D118135



More information about the llvm-commits mailing list