[PATCH] D118214: [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! For the `Transforms/ObjCARC` stuff it would be good for Akira to also take a quick look.



================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:4633
+
+void llvm::UpgradeOperandBundles(std::vector<OperandBundleDef> &Bundles) {
+
----------------
Any reason not to use a SmallVector?


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:4634
+void llvm::UpgradeOperandBundles(std::vector<OperandBundleDef> &Bundles) {
+
+  // clang.arc.attachedcall bundles are now required to have an operand.
----------------
nit: stray new line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118214/new/

https://reviews.llvm.org/D118214