[PATCH] D117689: [AArch64][SVE] Fold vselect into predicated fmul, fsub and fadd

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:8464
 
+class SVE_2_Op_Vselect_Passthru<SDPatternOperator op, SDPatternOperator inst> : PatFrags<(ops node:$Pg, node:$Op1, node:$Op2), [
+    (op node:$Pg, node:$Op1, node:$Op2),
----------------
I think better names might be:
`op` => `intrinsic`
`inst` => `sdnode`

Beware copying the names form the other SVE_... classes, which I think would be confusing. Because in those classes, `op` is the thing to match for and 'inst' is the replacement, which is not the case for your `PatFrags` where, both cases are actually things to match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117689/new/

https://reviews.llvm.org/D117689