[PATCH] D118141: [flang] Upstream partial lowering of EXIT intrinsic

[Josh Mottley via Phabricator via llvm-commits]

josh.mottley.arm marked 2 inline comments as done.
josh.mottley.arm added inline comments.


================
Comment at: flang/unittests/Optimizer/Builder/Runtime/RuntimeCallTestBase.h:123-126
+/// Check the operations in \p block for containing a `fir::CallOp` operation
+/// where its name matches \p fctName and the number of arguments is equal to \p
+/// nbArgs. Note that this check only cares if the operation exists, and not the
+/// order in when the operation is called.
----------------
awarzynski wrote:
> Could you refine this a bit? 
> 
> * "Check the operations in \p block for containing a `fir::CallOp` operation where its name matches \p fctName" -> this suggests that the name of `fir::CallOp` should be `fctName`, but in fact it's the function that `fir::CallOp` calls that's matched against `fctName`
> * This method will only check the first instance of `fir::CallOpt(fctName)`and exit, right? I think that that's fine, but worth documenting too.
Is this comment better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118141/new/

https://reviews.llvm.org/D118141