[PATCH] D89050: Add support for !noundef metatdata on loads

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 08:27:29 PST 2022


nikic added a comment.

In D89050#3272626 <https://reviews.llvm.org/D89050#3272626>, @malharJ wrote:

>> You might want to file an issue for the missing transform you encountered
>
> When you say missing transform, are you referring to C/C++ array access to LLVM IR load transform ?
>
> (If you are referring to the select --> and/or folding, it is not exactly missing, 
> rather it was disabled if the transformation was poison-unsafe (which is why
> I am trying to see if I can get the IR to generate well-defined loads.
> Since those loaded values are inputs to the select in my particular case.)
>
> Below were the patches.
> https://reviews.llvm.org/D99674
> https://reviews.llvm.org/D101191
> )

Right, but the absence of select -> and/or folding by itself shouldn't matter -- it's only relevant in that it can prevent other transforms. We tried to make sure that everything handles the select form as far as possible, but we may have missed something, which is why I'm asking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89050/new/

https://reviews.llvm.org/D89050



More information about the llvm-commits mailing list