[PATCH] D118250: AMDGPU: Mark control flow intrinsics non-duplicable
Ruiling, Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 26 07:32:04 PST 2022
ruiling added a comment.
In D118250#3272530 <https://reviews.llvm.org/D118250#3272530>, @arsenm wrote:
> I don't think this is a good idea. We don't actually need a structured CFG at this point, and tail duplicating isn't exactly unstructuring anyway. This is not an alternative to fixing the LiveVariables update problem, it's just the testcase that broke happened to have appeared due to tail duplication
Tail duplicating divergent branching is also pretty bad idea. Can you prove ANY benefit by duplicating divergent branching?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118250/new/
https://reviews.llvm.org/D118250
More information about the llvm-commits
mailing list