[PATCH] D118145: [AArch64][SVE] Avoid using ptrue for ptest in VECREDUCE_OR.

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 07:29:20 PST 2022


peterwaller-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:19359
   case ISD::VECREDUCE_OR:
-    return getPTest(DAG, VT, Pg, Op, AArch64CC::ANY_ACTIVE);
+    return getPTest(DAG, VT, Op, Op, AArch64CC::ANY_ACTIVE);
   case ISD::VECREDUCE_AND: {
----------------
The change makes sense but perhaps warrants a brief comment of why this is Op rather than Pg, since it's subtly different from the getPTest below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118145/new/

https://reviews.llvm.org/D118145



More information about the llvm-commits mailing list