[PATCH] D118162: [tblgen] Disable lsan weak hook when building with msvc

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

I'm a bit confused as to why this change is needed. My understanding is that `__SANITIZE_ADDRESS__` is only defined when the user passes `-fsanitize=address` (so they explicitly opted in). So isn't the issue here that the user asked for something unsupported and the solution is for them to not pass that compiler argument on Windows? Alternatively, should the fix be to require `__has_feature(leak_sanitizer)` to return true instead of using `||`?

(I'm a bit worried that we're carving out an exception for something that's feature testable and when the feature eventually gets supported on Windows, nobody will remember to go remove the special exceptions.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118162/new/

https://reviews.llvm.org/D118162