[PATCH] D118094: [InstCombine] Implementing (x & y) + ~(x | y) -> ~(x ^ y)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 04:30:53 PST 2022


lebedev.ri added a comment.

In D118094#3268592 <https://reviews.llvm.org/D118094#3268592>, @ChuanqiXu wrote:

> In D118094#3268554 <https://reviews.llvm.org/D118094#3268554>, @lebedev.ri wrote:
>
>> Please fix the patch's description.
>
> Do you mean the URL in the description? I would delete it when this one get committed.
>
>> Should this go into `have no common bits` check instead?
>
> I don't understand why this could go into "have no common bits". Since (x & y) and  ~(x | y) could have common bits 0 if x is 1 and y is 0. Did I misunderstand something?

https://alive2.llvm.org/ce/z/CxLDuT


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118094/new/

https://reviews.llvm.org/D118094



More information about the llvm-commits mailing list