[PATCH] D118048: [Dexter] Remove false requirement of lldb for dexter regression tests on Windows

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Folded nit-fixes into the commit, thanks both.



================
Comment at: cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_file/lit.local.cfg:1-3
+# FIXME: These tests compile code with %clang substituion which needs to run
+# natively but doesn't specify target triple (i.e. default triple is used).
+config.unsupported = True
----------------
jmorse wrote:
> StephenTozer wrote:
> > substituion -> substitution
> To be clear, we're making this unsupported everywhere because it won't work on our public buildbot, yes? This seems like a reasonable trade-off to me (some public coverage now vs no public coverage now), just checking the reasoning.
Yep, that's right


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118048/new/

https://reviews.llvm.org/D118048