[PATCH] D116895: Fix a missed opportunity to optimize consecutive stores.

Wed Jan 26 01:36:30 PST 2022

bjope added inline comments.

================
Comment at: llvm/test/CodeGen/Hexagon/store-widen-aliased-load.ll:1
-; RUN: llc -march=hexagon < %s | FileCheck %s
+; RUN: llc -march=hexagon --combiner-store-merging=false < %s | FileCheck %s
 ; CHECK-NOT: memh
----------------
bjope wrote:
> Why are you disabling the combiner-store-merging in this test case? Looks like a typo?
> 
> Reading the comment history in this ticket I got a feeling that this test case was added to verify that no store merge happened in this case. But then it seems really weird to verify that in a test case were the store merging is disabled.
> 
> Maybe there should be two RUN-lines, expecting the same result regardless if combiner-store-merging is true or false?
Aw, sorry, I now realize that the test case you added for the alias situation was in test/CodeGen/X86/MergeConsecutiveStores.ll.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116895/new/

https://reviews.llvm.org/D116895