[PATCH] D118166: [InstrProf][Correlate] Improve error messages

Kyungwoo Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 26 00:08:07 PST 2022


kyulee added a comment.

This looks reasonable by sharing a common error message concatenated by the detailed reasons as needed instead of populating all the error cases.
Unless this violates coding convention with regard to error messages, it looks good to me. I'm approving it but want to hear other reviewers' opinions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118166/new/

https://reviews.llvm.org/D118166



More information about the llvm-commits mailing list