[PATCH] D118217: [RISCV] Fix support of vlen = 64.
Jianjian Guan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 25 23:54:57 PST 2022
jacquesguan created this revision.
jacquesguan added reviewers: craig.topper, eopXD, asb, luismarques, frasercrmck, HsiangKai, khchen, benshi001.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya.
jacquesguan requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, MaskRay.
Herald added a project: LLVM.
In the Zve* extensions, the vlen could be 64. This patch change the vlen constraint of low bound to 64.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D118217
Files:
llvm/lib/Target/RISCV/RISCVSubtarget.cpp
Index: llvm/lib/Target/RISCV/RISCVSubtarget.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVSubtarget.cpp
+++ llvm/lib/Target/RISCV/RISCVSubtarget.cpp
@@ -149,15 +149,16 @@
"than the Zvl*b limitation");
// FIXME: Change to >= 32 when VLEN = 32 is supported
- assert(RVVVectorBitsMax >= 64 && RVVVectorBitsMax <= 65536 &&
- isPowerOf2_32(RVVVectorBitsMax) &&
- "V extension requires vector length to be in the range of 128 to "
- "65536 and a power of 2!");
+ assert(
+ RVVVectorBitsMax >= 64 && RVVVectorBitsMax <= 65536 &&
+ isPowerOf2_32(RVVVectorBitsMax) &&
+ "V or Zve* extension requires vector length to be in the range of 64 to "
+ "65536 and a power of 2!");
assert(RVVVectorBitsMax >= RVVVectorBitsMin &&
"Minimum V extension vector length should not be larger than its "
"maximum!");
unsigned Max = std::max(RVVVectorBitsMin, RVVVectorBitsMax);
- return PowerOf2Floor((Max < 128 || Max > 65536) ? 0 : Max);
+ return PowerOf2Floor((Max < 64 || Max > 65536) ? 0 : Max);
}
unsigned RISCVSubtarget::getMinRVVVectorSizeInBits() const {
@@ -170,18 +171,19 @@
assert(hasVInstructions() &&
"Tried to get vector length without Zve or V extension support!");
// FIXME: Change to >= 32 when VLEN = 32 is supported
- assert((RVVVectorBitsMin == 0 ||
- (RVVVectorBitsMin >= 64 && RVVVectorBitsMax <= 65536 &&
- isPowerOf2_32(RVVVectorBitsMin))) &&
- "V extension requires vector length to be in the range of 128 to "
- "65536 and a power of 2!");
+ assert(
+ (RVVVectorBitsMin == 0 ||
+ (RVVVectorBitsMin >= 64 && RVVVectorBitsMin <= 65536 &&
+ isPowerOf2_32(RVVVectorBitsMin))) &&
+ "V or Zve* extension requires vector length to be in the range of 64 to "
+ "65536 and a power of 2!");
assert((RVVVectorBitsMax >= RVVVectorBitsMin || RVVVectorBitsMax == 0) &&
"Minimum V extension vector length should not be larger than its "
"maximum!");
unsigned Min = RVVVectorBitsMin;
if (RVVVectorBitsMax != 0)
Min = std::min(RVVVectorBitsMin, RVVVectorBitsMax);
- return PowerOf2Floor((Min < 128 || Min > 65536) ? 0 : Min);
+ return PowerOf2Floor((Min < 64 || Min > 65536) ? 0 : Min);
}
unsigned RISCVSubtarget::getMaxLMULForFixedLengthVectors() const {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118217.403151.patch
Type: text/x-patch
Size: 2426 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220126/89e19d9e/attachment.bin>
More information about the llvm-commits
mailing list