[PATCH] D118216: [RISCV][NFC] eliminate rematerialization ofarray's base address

Haocong Lu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 23:46:26 PST 2022


Luhaocong created this revision.
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya.
Luhaocong requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, jacquesguan, MaskRay.
Herald added a project: LLVM.

https://reviews.llvm.org/D118216

Files:
  llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
  llvm/test/CodeGen/RISCV/unroll-loop-cse.ll


Index: llvm/test/CodeGen/RISCV/unroll-loop-cse.ll
===================================================================
--- llvm/test/CodeGen/RISCV/unroll-loop-cse.ll
+++ llvm/test/CodeGen/RISCV/unroll-loop-cse.ll
@@ -16,28 +16,20 @@
 ; RV32I-NEXT:    bne a3, a4, .LBB0_6
 ; RV32I-NEXT:  # %bb.1:
 ; RV32I-NEXT:    addi a1, a1, %lo(x)
-; RV32I-NEXT:    lw a1, 4(a1)
+; RV32I-NEXT:    lw a3, 4(a1)
 ; RV32I-NEXT:    addi a2, a2, %lo(check)
-; RV32I-NEXT:    lw a2, 4(a2)
-; RV32I-NEXT:    bne a1, a2, .LBB0_6
+; RV32I-NEXT:    lw a4, 4(a2)
+; RV32I-NEXT:    bne a3, a4, .LBB0_6
 ; RV32I-NEXT:  # %bb.2:
-; RV32I-NEXT:    lui a1, %hi(x)
-; RV32I-NEXT:    addi a1, a1, %lo(x)
 ; RV32I-NEXT:    lw a3, 8(a1)
-; RV32I-NEXT:    lui a2, %hi(check)
-; RV32I-NEXT:    addi a2, a2, %lo(check)
 ; RV32I-NEXT:    lw a4, 8(a2)
 ; RV32I-NEXT:    bne a3, a4, .LBB0_6
 ; RV32I-NEXT:  # %bb.3:
-; RV32I-NEXT:    lw a1, 12(a1)
-; RV32I-NEXT:    lw a2, 12(a2)
-; RV32I-NEXT:    bne a1, a2, .LBB0_6
+; RV32I-NEXT:    lw a3, 12(a1)
+; RV32I-NEXT:    lw a4, 12(a2)
+; RV32I-NEXT:    bne a3, a4, .LBB0_6
 ; RV32I-NEXT:  # %bb.4:
-; RV32I-NEXT:    lui a1, %hi(x)
-; RV32I-NEXT:    addi a1, a1, %lo(x)
 ; RV32I-NEXT:    lw a3, 16(a1)
-; RV32I-NEXT:    lui a2, %hi(check)
-; RV32I-NEXT:    addi a2, a2, %lo(check)
 ; RV32I-NEXT:    lw a4, 16(a2)
 ; RV32I-NEXT:    bne a3, a4, .LBB0_6
 ; RV32I-NEXT:  # %bb.5:
Index: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
+++ llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
@@ -1071,6 +1071,8 @@
     return (MI.getOperand(1).isReg() &&
             MI.getOperand(1).getReg() == RISCV::X0) ||
            (MI.getOperand(2).isImm() && MI.getOperand(2).getImm() == 0);
+  case RISCV::LUI:
+    return MI.getOperand(1).getTargetFlags() != RISCVII::MO_HI;
   }
   return MI.isAsCheapAsAMove();
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118216.403147.patch
Type: text/x-patch
Size: 1906 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220126/61ffa4f8/attachment.bin>


More information about the llvm-commits mailing list