[PATCH] D118115: [AVR][NFC] Improve CodeGen tests

Tue Jan 25 19:08:33 PST 2022

benshi001 added a comment.

In D118115#3270522 <https://reviews.llvm.org/D118115#3270522>, @MaskRay wrote:

> I don't think we should clutter up tests. `-DLLVM_ENABLE_EXPENSIVE_CHECKS=on` implies `-verify-machineinstrs`. There may be a proposal to enable `-verify-machineinstrs` automatically.
>
> The problem may be to ensure `isMachineVerifierClean` returning false for AVR is correct.

Thanks. The AVRTargetMachine does not inherit the virtual base `isMachineVerifierClean` and always get true with `-DLLVM_ENABLE_EXPENSIVE_CHECKS=on`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118115/new/

https://reviews.llvm.org/D118115