[PATCH] D117562: [AMDGPU] Sink immediate VGPR defs if high RP

[Vang Thao via Phabricator via llvm-commits]

vangthao added a comment.

In D117562#3270527 <https://reviews.llvm.org/D117562#3270527>, @rampitec wrote:

> Looking at the patch and given we cannot do it in RA itself I start to think that scheduler is better suited for this job, maybe as an extra last step. It already has our RPTracker and collected all that info, so I guess it shall be less code. Plus all of the sinking may be not needed if scheduler was able to improve the occupancy.

I agree that it would be best to perform this sinking during or after scheduling to see if we really need to sink these instructions. Can this be implemented in a follow-up patch? Will need to spend more time looking into the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117562/new/

https://reviews.llvm.org/D117562