[llvm] 1c82fdb - Revert "Fix build issue in assert mode introduced by 6427f4c52c31cc36004"

[Nico Weber via llvm-commits]

Author: Nico Weber
Date: 2022-01-25T16:35:33-05:00
New Revision: 1c82fdb3d174b00ceab49e1f6e355c228f45048f

URL: https://github.com/llvm/llvm-project/commit/1c82fdb3d174b00ceab49e1f6e355c228f45048f
DIFF: https://github.com/llvm/llvm-project/commit/1c82fdb3d174b00ceab49e1f6e355c228f45048f.diff

LOG: Revert "Fix build issue in assert mode introduced by 6427f4c52c31cc36004"

This reverts commit d65a3b3265d058ce1f0ac82fa4d0826bf1b2bbaf.
Breaks build everywhere, see e.g. http://45.33.8.238/linux/66344/step_4.txt
or https://lab.llvm.org/buildbot/#/builders/139/builds/16811

Added: 
    

Modified: 
    llvm/lib/Support/CommandLine.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp
index c61e3c00737a..e517ceb05d9b 100644
--- a/llvm/lib/Support/CommandLine.cpp
+++ b/llvm/lib/Support/CommandLine.cpp
@@ -2356,9 +2356,7 @@ class CategorizedHelpPrinter : public HelpPrinter {
     for (size_t I = 0, E = Opts.size(); I != E; ++I) {
       Option *Opt = Opts[I].second;
       for (auto &Cat : Opt->Categories) {
-        assert(std::binary_search(SortedCategories.begin(),
-                                  SortedCategories.end(), Cat,
-                                  OptionCategoryCompare) &&
+        assert(CategorizedOptions.count(Cat) > 0 &&
                "Option has an unregistered category");
         CategorizedOptions[Cat].push_back(Opt);
       }