[PATCH] D117612: [BOLT] Update dynamic relocations from section relocations

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 10:32:16 PST 2022


yota9 added inline comments.


================
Comment at: bolt/include/bolt/Rewrite/RewriteInstance.h:440
+  /// Stores true if relocation of specified type is came from .rela.plt
+  std::map<uint64_t, bool> IsJmpRelocation;
+
----------------
maksfb wrote:
> `DenseMap` is a better choice, maybe even `IndexedMap`.
You're right, DenseMap is a bit of a better choice here. IndexedMap will consume more memory as I remember, since relocation type number might be quite big.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117612/new/

https://reviews.llvm.org/D117612



More information about the llvm-commits mailing list