[PATCH] D102707: Fix non-global-value-max-name-size not considered by LLParser

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

> My guess is that due to the `Name = Name.substr(0, std::max(1u, (unsigned)MaxNameSize));` in `createValueName`, a great many temporary StringRefs are created and destroyed?

Creating a StringRef is "free".

Your profile shows a great amount of maps lookup though. It can be that the map size exploded for some reason or that we query it much more?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102707/new/

https://reviews.llvm.org/D102707