[PATCH] D118073: [IVDescriptor] Get the exact FP instruction that does not allow reordering

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 09:32:52 PST 2022


kmclaughlin accepted this revision.
kmclaughlin added a comment.
This revision is now accepted and ready to land.

Thank you for this fix @congzhe, LGTM! I have just added one minor comment on the new test.



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/strict-fadd.ll:593
+; CHECK-ORDERED-NOT: vector.body
+
+; CHECK-NOT-VECTORIZED-LABEL: @fadd_multiple_one_flag
----------------
Can you please add some `CHECK-UNORDERED` lines here? I believe for this test we should vectorise when reordering is allowed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118073/new/

https://reviews.llvm.org/D118073



More information about the llvm-commits mailing list