[PATCH] D118139: [AArch64][SVE][VLS] Move extends into arguments of comparisons

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15341
 
+static bool isCheapToExtend(const SDValue &N) {
+  unsigned OC = N->getOpcode();
----------------
Perhaps I'm being pedantic but do you mean "cheap" or do you mean "zero cost"?


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15363-15373
+  ISD::NodeType ExtType;
+  switch (Code) {
+  case ISD::SETULT:
+  case ISD::SETULE:
+  case ISD::SETUGT:
+  case ISD::SETUGE:
+    ExtType = ISD::ZERO_EXTEND;
----------------
`ISDOpcode.h` has the helper function isSignedIntSetCC()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118139/new/

https://reviews.llvm.org/D118139