[PATCH] D115128: [TableGen][CodeEmitter] Introducing the VarLenCodeEmitterGen infrastructure

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 06:04:01 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/utils/TableGen/VarLenCodeEmitterGen.cpp:124
+void VarLenCodeEmitterGen::VarLenInst::buildRec(const DagInit *DI) {
+  auto Op = DI->getOperator()->getAsString();
+
----------------
(style) Don't use auto for non-obvious return types (could be StringRef / std::string / const std::string& .......)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115128/new/

https://reviews.llvm.org/D115128



More information about the llvm-commits mailing list