[PATCH] D118117: [Visualizers] Fix Optional visualizer.

Marek Kurdej via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 05:16:09 PST 2022


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4100cf2e9259: [Visualizers] Fix Optional visualizer. (authored by curdeius).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118117/new/

https://reviews.llvm.org/D118117

Files:
  llvm/utils/LLVMVisualizers/llvm.natvis


Index: llvm/utils/LLVMVisualizers/llvm.natvis
===================================================================
--- llvm/utils/LLVMVisualizers/llvm.natvis
+++ llvm/utils/LLVMVisualizers/llvm.natvis
@@ -197,9 +197,9 @@
   
   <Type Name="llvm::Optional<*>">
     <DisplayString Condition="!Storage.hasVal">None</DisplayString>
-    <DisplayString Condition="Storage.hasVal">{*(($T1 *)(unsigned char *)Storage.storage.buffer)}</DisplayString>
+    <DisplayString Condition="Storage.hasVal">{Storage.value}</DisplayString>
     <Expand>
-      <Item Name="[underlying]" Condition="Storage.hasVal">*(($T1 *)(unsigned char *)Storage.storage.buffer)</Item>
+      <Item Name="[underlying]" Condition="Storage.hasVal">Storage.value</Item>
     </Expand>
   </Type>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118117.402866.patch
Type: text/x-patch
Size: 779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220125/bbb6e547/attachment.bin>


More information about the llvm-commits mailing list