[PATCH] D118125: [bazel] Enable layering_check for MLIR test directory

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 04:44:25 PST 2022


rupprecht created this revision.
rupprecht added a reviewer: bkramer.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
rupprecht requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.

This would have enabled me to notice the MLIR test file needed updating too, preventing the test file of 2074eef5db330ab437410bfb617b58ea70f4fbff <https://reviews.llvm.org/rG2074eef5db330ab437410bfb617b58ea70f4fbff> from being necessary.

layering_check is already enabled in mlir/BUILD.bazel. I don't know why I didn't see the other breakage there.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118125

Files:
  utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
@@ -6,6 +6,7 @@
 
 package(
     default_visibility = ["//visibility:public"],
+    features = ["layering_check"],
     licenses = ["notice"],
 )
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118125.402852.patch
Type: text/x-patch
Size: 396 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220125/96cfba87/attachment.bin>


More information about the llvm-commits mailing list