[PATCH] D118057: [AArch64][SVE] Implement missing lowering for extract_subvector for predicates.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 04:27:18 PST 2022


sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-insert-vector.ll:557
+; CHECK-NEXT:    ret
+  %v0 = call <vscale x 16 x i1> @llvm.experimental.vector.insert.nx16i1.nxv4i1(<vscale x 16 x i1> zeroinitializer, <vscale x 4 x i1> %sv, i64 0)
+  ret <vscale x 16 x i1> %v0
----------------
efriedma wrote:
> I don't get this.  `<vscale x 4 x i1>` doesn't have the right layout; it has padding bits in between each value bit.
You're right, I had my wires crossed here, thanks for pointing out!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118057/new/

https://reviews.llvm.org/D118057



More information about the llvm-commits mailing list