[PATCH] D118121: [WebAssembly] Refactor WasmSymbol type setting code

Paulo Matos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 25 04:05:02 PST 2022


pmatos updated this revision to Diff 402838.
pmatos added a comment.

@sbc100 Address review comments from D115749 <https://reviews.llvm.org/D115749>.

Make WasmSymbolSetType lower case to match what other functions in 
WebAssemblyTypeUtilities do.

Also, this function is shared between MCInstLower and AsmPrinter, 
therefore it needs to be in a common Utilities file. Since this 
deals with types, it makes sense for that file to be 
WebAssemblyTypeUtilities.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118121/new/

https://reviews.llvm.org/D118121

Files:
  llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.cpp
  llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.h
  llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h
  llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyLowerRefTypesIntPtrConv.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyMachineFunctionInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118121.402838.patch
Type: text/x-patch
Size: 13616 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220125/83e9aebc/attachment.bin>


More information about the llvm-commits mailing list